Erlang Mailing Lists
Author Message

<  Erlang patches mailing list  ~  Complexity Shock Horror II: the Sequel (was MD5 in erlang.)
cpressey at catseye.mb.ca
Posted: Sat Apr 12, 2003 8:03 pm Reply with quote
Guest
On Fri, 11 Apr 2003 23:22:46 -0500
Chris Pressey <cpressey_at_catseye.mb.ca> wrote:

> (Errr... you *are* going to add to_upper/1 and to_lower/1 to the
> string module... right? Or are those still going to be officially
> classified as 'httpd helper functions'? :)

In an attempt to dislodge Matthias from his chair, here is a patch
against R9B-1 that puts these functions in their place.

If this is something the OTP team wants, I can make a better patch in
the near future (tail-recursive, fixup the references in httpd_*.erl,
etc.)

-Chris


Post generated using Mail2Forum (http://m2f.sourceforge.net)
Back to top
cpressey at catseye.mb.ca
Posted: Sun Apr 13, 2003 2:22 am Reply with quote
Guest
On Sat, 12 Apr 2003 15:03:27 -0500
Chris Pressey <cpressey_at_catseye.mb.ca> wrote:

> If this is something the OTP team wants, I can make a better patch in
> the near future (tail-recursive, fixup the references in httpd_*.erl,
> etc.)

Done this now, see attached patch
(also contains my older patch for regexp and a few minor tweaks to other
files (e.g. -include to -include_lib so I could recompile it easily)

math:base/2 returns the same (goofy) error codes as
httpd_util:hexlist_to_integer/1 and httpd_util:integer_to_hexlist/1

It does NOT, however, simulate the what-I'd-consider-broken behaviour of
httpd_util:hexlist_to_integer/1:

Eshell V5.2.3.3 (abort with ^G)
1> httpd_util:hexlist_to_integer("3G5").
3
2> httpd_util:hexlist_to_integer("-3F5").
0

Instead it returns 'error' or 'not_a_num' for negative values, as the
httpd_util functions do, on the errors that they do detect.

-Chris


Post generated using Mail2Forum (http://m2f.sourceforge.net)
Back to top
robert.virding at telia.c
Posted: Sun Apr 13, 2003 7:02 pm Reply with quote
Guest
Yes, add these!

Robert

----- Original Message -----
From: "Chris Pressey" <cpressey_at_catseye.mb.ca>
To: <erlang-questions_at_erlang.org>
Cc: <erlang-patches_at_erlang.org>
Sent: Saturday, April 12, 2003 10:03 PM
Subject: Re: Complexity Shock Horror II: the Sequel (was Re: MD5 in erlang.)


> On Fri, 11 Apr 2003 23:22:46 -0500
> Chris Pressey <cpressey_at_catseye.mb.ca> wrote:
>
> > (Errr... you *are* going to add to_upper/1 and to_lower/1 to the
> > string module... right? Or are those still going to be officially
> > classified as 'httpd helper functions'? Smile
>
> In an attempt to dislodge Matthias from his chair, here is a patch
> against R9B-1 that puts these functions in their place.
>
> If this is something the OTP team wants, I can make a better patch in
> the near future (tail-recursive, fixup the references in httpd_*.erl,
> etc.)
>
> -Chris
>


Post generated using Mail2Forum (http://m2f.sourceforge.net)
Back to top

Display posts from previous:  

All times are GMT
View next topic
View previous topic
Page 1 of 1
Erlang Forum - Trap Exit Forum Index  ~  Erlang patches mailing list
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
Hosted by Erlang Solutions    |    Powered by phpBB and NoseBleed v1.14