Erlang Mailing Lists
Author Message

<  Yaws mailing list  ~  Authentication headers question
diyu01
Posted: Thu Nov 19, 2009 8:55 pm Reply with quote
Joined: 19 Aug 2009 Posts: 7
Hi, from the source code of yaws_config.erl, it looks like if I use an authentication module, I must provide an authentication header by exporting a get_header() function, otherwise the Auth#auth.header field will be empty (because PAM is disabled and no user/password pair is given). This makes it difficult to share the same authentication module code between different servers with different realms. Can we change the code in one of the following three ways?

(1) in the handling of </auth>, if header field remains empty AND an authentication module name is given, then use the realm field to construct a default authentication header
(2) pass a parameter
Back to top View user's profile Send private message
diyu01
Posted: Fri Nov 20, 2009 12:04 am Reply with quote
Joined: 19 Aug 2009 Posts: 7
For the first option, the change can be from (line 1230 onwards of yaws_config.erl):

['<', "/auth", '>'] ->
Back to top View user's profile Send private message
Guest
Posted: Tue Dec 01, 2009 10:53 pm Reply with quote
Guest
Yu Di wrote:
> For the first option, the change can be from (line 1230 onwards of
> yaws_config.erl):

I think this looks good, sorry for being slow to respond to this.

I rewrote your patch and CC Anders Dahlin here.
Anders what do you think of the attached patch. As fas as I can judge
it looks good.


/klacke





Post received from mailinglist
Back to top
Guest
Posted: Wed Dec 02, 2009 9:30 am Reply with quote
Guest
Claes Wikstrom wrote:
> Yu Di wrote:
>> For the first option, the change can be from (line 1230 onwards of
>> yaws_config.erl):
>
> I think this looks good, sorry for being slow to respond to this.
>
> I rewrote your patch and CC Anders Dahlin here.
> Anders what do you think of the attached patch. As fas as I can judge
> it looks good.
>
>
> /klacke

I think that this should maybe be attacked a bit different. The reason
is the discrepancy between setting the auth from a file (auth file or
server config) and embedded using yaws_api:setconf. Using setconf you
are not assured that the auth headers are there at all. If read from a
file, it will be there. But all ways pass yaws_config:setup_auth, so
adding something that ensures that the headers are present there seems
better. This is assuming that they should never be empty in an auth
record. In that case, something like the attached (untested, uncompiled)
should be ok.

/Anders



Post received from mailinglist
Back to top
Guest
Posted: Wed Dec 02, 2009 9:34 am Reply with quote
Guest
Anders Dahlin wrote:
> I think that this should maybe be attacked a bit different.

Excellent,

Yu Di, please test that Anders patch solves your problem and then I'll
apply his patch instead.

Thanks

/klacke

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post received from mailinglist
Back to top
Guest
Posted: Wed Dec 02, 2009 5:01 pm Reply with quote
Guest
Yu Di wrote:
> Thanks! I tried this patch and it works.

Excellent, I applied and pushed the patch, so it'll be part
of next yaws release.


Thanks

/klacke

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post received from mailinglist
Back to top

Display posts from previous:  

All times are GMT
View next topic
View previous topic
Page 1 of 1
Erlang Forum - Trap Exit Forum Index  ~  Yaws mailing list
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum
Hosted by Erlang Solutions    |    Powered by phpBB and NoseBleed v1.14