Erlang Mailing Lists

Author Message

<  Yaws mailing list  ~  Yaws 1-86 ignores id in yaws.conf

Guest
Posted: Sun Dec 13, 2009 12:43 am Reply with quote
Guest
Hello!

When yaws is started with a yaws.conf file that specifies some id =
..., yaws disregards that setting.

Here's why (I think):

With --id not specified, bin/yaws defaults to --id=default

yaws_sup:get_app_args/0 returns #env with #env.id set to default
(because it wasn't undefined).

In yaws_config:fload/7 the following guards fail because #gconf.id is
default, not "default":

["id", '=', String] when GC#gconf.id == undefined;
GC#gconf.id == "default" -> ...

And we get the "Ignoring 'id ..." message.

Right?

Perhaps the correct solution is for bin/yaws to omit the default id
parameter. Even if fload/7 is tweaked to look for 'default' instead
of "default" (and id from yaws.conf processed correctly), "ps -ax |
grep yaws" will still show a yaws system running with "id default",
which is misleading.

Andrei

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post received from mailinglist
Guest
Posted: Sun Dec 13, 2009 9:47 pm Reply with quote
Guest
On Sat, Dec 12, 2009 at 7:42 PM, Andrei Soroker <soroker@gmail.com (soroker@gmail.com)> wrote:
Quote:
Hello!

When yaws is started with a yaws.conf file that specifies some id =
..., yaws disregards that setting.

Here's why (I think):

With --id not specified, bin/yaws defaults to --id=default

yaws_sup:get_app_args/0 returns #env with #env.id set to default
(because it wasn't undefined).

In yaws_config:fload/7 the following guards fail because #gconf.id is
default, not "default":

["id", '=', String] when GC#gconf.id == undefined;
Guest
Posted: Tue Dec 15, 2009 4:31 am Reply with quote
Guest
On Sun, Dec 13, 2009 at 4:46 PM, Steve Vinoski <vinoski@ieee.org (vinoski@ieee.org)> wrote:
Quote:

On Sat, Dec 12, 2009 at 7:42 PM, Andrei Soroker <soroker@gmail.com (soroker@gmail.com)> wrote:
Quote:
Hello!

When yaws is started with a yaws.conf file that specifies some id =
..., yaws disregards that setting.


Agreed. I've made changes to this effect but I'd like to get Klacke to review them before I put them on github master.



Changes pushed to github.


thanks,
--steve

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum