Erlang Mailing Lists
Author Message

<  Erlang bugs mailing list  ~  Fix building error of SCTP in FreeBSD 7.1 and later
jj1bdx
Posted: Wed Feb 10, 2010 1:53 pm Reply with quote
User Joined: 11 Sep 2008 Posts: 92
git fetch git://github.com/jj1bdx/otp.git r13b03_sctp_freebsd

Fix building error of SCTP in FreeBSD 7.1 and later

This patch fixes building error of SCTP in FreeBSD 7.1 and later.

See
http://www.erlang.org/cgi-bin/ezmlm-cgi?2:mss:1257:200904:hppnfialjjdlgecdiehe
for the details.

Patch summary:

R13A patch for solving a compilation error when building
erts/emulator/drivers/common/inet_drv.c
by Kenji Rikitake 12-APR-2009

Symptom solved by this patch:

When building R13A in FreeBSD 7.1-RELEASE,
the compiler flag
HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
is NOT enabled.
Some code in
erts/emulator/drivers/common/inet_drv.c
incorrectly assumes
HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
is always true when
HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_FLAGS
is true in config.h.
This assumption causes a compilation error.

Regards,
Kenji Rikitake

________________________________________________________________
erlang-bugs (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-bugs-unsubscribe@erlang.org

Post received from mailinglist
Back to top View user's profile Send private message
Guest
Posted: Wed Feb 10, 2010 3:40 pm Reply with quote
Guest
On Wed, Feb 10, 2010 at 10:52:07PM +0900, Kenji Rikitake wrote:
> git fetch git://github.com/jj1bdx/otp.git r13b03_sctp_freebsd
>
> Fix building error of SCTP in FreeBSD 7.1 and later
>
> This patch fixes building error of SCTP in FreeBSD 7.1 and later.
>
> See
> http://www.erlang.org/cgi-bin/ezmlm-cgi?2:mss:1257:200904:hppnfialjjdlgecdiehe
> for the details.

It seems Giacomo Olgeni's patch that this patch depends on
is missing. erts/configure will not define
HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY so it will
be disabled on all platforms even the ones that have
that flag... And that would be bad.

See also:
http://www.erlang.org/cgi-bin/ezmlm-cgi/2/1264
sorry about me not managing to rework that issue,
other emergencies came in the way...

>
> Patch summary:
>
> R13A patch for solving a compilation error when building
> erts/emulator/drivers/common/inet_drv.c
> by Kenji Rikitake 12-APR-2009
>
> Symptom solved by this patch:
>
> When building R13A in FreeBSD 7.1-RELEASE,
> the compiler flag
> HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
> is NOT enabled.
> Some code in
> erts/emulator/drivers/common/inet_drv.c
> incorrectly assumes
> HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
> is always true when
> HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_FLAGS
> is true in config.h.
> This assumption causes a compilation error.
>
> Regards,
> Kenji Rikitake
>
> ________________________________________________________________
> erlang-bugs (at) erlang.org mailing list.
> See http://www.erlang.org/faq.html
> To unsubscribe; mailto:erlang-bugs-unsubscribe@erlang.org

--

/ Raimo Niskanen, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-bugs (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-bugs-unsubscribe@erlang.org

Post received from mailinglist
Back to top
jj1bdx
Posted: Wed Feb 10, 2010 11:47 pm Reply with quote
User Joined: 11 Sep 2008 Posts: 92
Raimo:

Thanks for comments. I will rework this patch after R13B04 comes out.
(I have other higher-priority projects than this one)

Kenji Rikitake

In the message <20100210153945.GA22452@erix.ericsson.se>
dated Wed, Feb 10, 2010 at 04:39:21PM +0100,
Raimo Niskanen <raimo+erlang-bugs@erix.ericsson.se> writes:
> On Wed, Feb 10, 2010 at 10:52:07PM +0900, Kenji Rikitake wrote:
> > git fetch git://github.com/jj1bdx/otp.git r13b03_sctp_freebsd
> >
> > Fix building error of SCTP in FreeBSD 7.1 and later
> >
> > This patch fixes building error of SCTP in FreeBSD 7.1 and later.
> >
> > See
> > http://www.erlang.org/cgi-bin/ezmlm-cgi?2:mss:1257:200904:hppnfialjjdlgecdiehe
> > for the details.
>
> It seems Giacomo Olgeni's patch that this patch depends on
> is missing. erts/configure will not define
> HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY so it will
> be disabled on all platforms even the ones that have
> that flag... And that would be bad.
>
> See also:
> http://www.erlang.org/cgi-bin/ezmlm-cgi/2/1264
> sorry about me not managing to rework that issue,
> other emergencies came in the way...
>
> >
> > Patch summary:
> >
> > R13A patch for solving a compilation error when building
> > erts/emulator/drivers/common/inet_drv.c
> > by Kenji Rikitake 12-APR-2009
> >
> > Symptom solved by this patch:
> >
> > When building R13A in FreeBSD 7.1-RELEASE,
> > the compiler flag
> > HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
> > is NOT enabled.
> > Some code in
> > erts/emulator/drivers/common/inet_drv.c
> > incorrectly assumes
> > HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
> > is always true when
> > HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_FLAGS
> > is true in config.h.
> > This assumption causes a compilation error.
> >
> > Regards,
> > Kenji Rikitake

________________________________________________________________
erlang-bugs (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-bugs-unsubscribe@erlang.org

Post received from mailinglist
Back to top View user's profile Send private message

Display posts from previous:  

All times are GMT
View next topic
View previous topic
Page 1 of 1
Erlang Forum - Trap Exit Forum Index  ~  Erlang bugs mailing list
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
Hosted by Erlang Solutions    |    Powered by phpBB and NoseBleed v1.14