| Author |
Message |
|
| Guest |
 Posted: Wed May 19, 2010 2:50 pm |
 |
|
|
Guest
|
|
| Back to top |
|
| Guest |
| Posted: Wed May 19, 2010 2:50 pm |
|
|
|
Guest
|
|
| Back to top |
|
| Guest |
| Posted: Wed May 19, 2010 3:03 pm |
|
|
|
Guest
|
Your changes are perfectly fine for me.
Please go on.
cheers
2010/5/19 Björn Gustavsson <bgustavsson@gmail.com>
> We hope to graduate this branch soon, but with
> a few changes:
>
> The get_int64() macro that you used did not actually
> work (it was not actually used before), so I have corrected
> it in a separate commit:
>
>
> http://github.com/bjorng/otp/commit/1a4c6275d3cb1d91db376a854bdda083c63f0feb
>
>
> I also did a minor clean-up in a commit that is separate now, but
> I want to combine it with your commit:
>
>
> http://github.com/bjorng/otp/commit/1d477960292a6065231763e9691949aac818d3a8
>
> If you don't like this change, please tell us so as soon as possible.
>
>
> Here is the fetch command to fetch the updated branch:
>
> git fetch git://github.com/bjorng/otp.git fm/file-operations
>
> --
> Björn Gustavsson, Erlang/OTP, Ericsson AB
>
--
Filipe David Manana,
fdmanana@gmail.com
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Wed May 19, 2010 3:03 pm |
|
|
|
Guest
|
Your changes are perfectly fine for me.
Please go on.
cheers
2010/5/19 Björn Gustavsson <bgustavsson@gmail.com>
> We hope to graduate this branch soon, but with
> a few changes:
>
> The get_int64() macro that you used did not actually
> work (it was not actually used before), so I have corrected
> it in a separate commit:
>
>
> http://github.com/bjorng/otp/commit/1a4c6275d3cb1d91db376a854bdda083c63f0feb
>
>
> I also did a minor clean-up in a commit that is separate now, but
> I want to combine it with your commit:
>
>
> http://github.com/bjorng/otp/commit/1d477960292a6065231763e9691949aac818d3a8
>
> If you don't like this change, please tell us so as soon as possible.
>
>
> Here is the fetch command to fetch the updated branch:
>
> git fetch git://github.com/bjorng/otp.git fm/file-operations
>
> --
> Björn Gustavsson, Erlang/OTP, Ericsson AB
>
--
Filipe David Manana,
fdmanana@gmail.com
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
Post received from mailinglist |
|
|
| Back to top |
|
| t |
| Posted: Wed May 19, 2010 3:49 pm |
|
|
|
User
Joined: 30 Sep 2008
Posts: 133
|
|
| Back to top |
 
|
| t |
| Posted: Wed May 19, 2010 3:49 pm |
|
|
|
User
Joined: 30 Sep 2008
Posts: 133
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 8:59 am |
|
|
|
Guest
|
2010/5/19 Tuncer Ayaz <tuncer.ayaz@gmail.com>:
> I would prefer the documentation to be more in line with the existing
> text in file.xml, use the same order of advise values as in the
> original manpage and be less specific about the effect.
I also like your version better, except for a minor detail
which I have marked below.
Filipe, is this change OK for you?
> --- a/file.xml
> +++ b/file.xml
> @@ -69,16 +69,15 @@ time() = {{Year, Month, Day}, {Hour, Minute, Second}}
> <v>Offset = int()</v>
> <v>Length = int()</v>
> <v>Advise = posix_file_advise()</v>
> - <v>posix_file_advise() = normal | sequential | random | will_need
> - | dont_need | no_reuse</v>
> + <v>posix_file_advise() = normal | sequential | random | no_reuse
> + | will_need | dont_need</v>
> <v>Reason = ext_posix()</v>
> </type>
> <desc>
> - <p>This function allows the Operating System to perform caching
> - optimizations for accessing a file's data.</p>
> - <p>This function is available only on POSIX compliant systems.
> - For systems that are not POSIX compliant, this function has
> - no effect when invoked.</p>
> + <p><c>advise</c> can be used to announce an intention to access file
In the documentation, we include the arity when referring to a function.
Thus:
<p><c>advise/4</c> can be used to announce an intention to access file
> + data in a specific pattern in the future, thus allowing the
> + operating system to perform appropriate optimizations.</p>
> + <p>On some platforms, this function might have no effect.</p>
> </desc>
> </func>
> <func>
>
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 9:00 am |
|
|
|
Guest
|
2010/5/19 Tuncer Ayaz <tuncer.ayaz@gmail.com>:
> I would prefer the documentation to be more in line with the existing
> text in file.xml, use the same order of advise values as in the
> original manpage and be less specific about the effect.
I also like your version better, except for a minor detail
which I have marked below.
Filipe, is this change OK for you?
> --- a/file.xml
> +++ b/file.xml
> @@ -69,16 +69,15 @@ time() = {{Year, Month, Day}, {Hour, Minute, Second}}
> <v>Offset = int()</v>
> <v>Length = int()</v>
> <v>Advise = posix_file_advise()</v>
> - <v>posix_file_advise() = normal | sequential | random | will_need
> - | dont_need | no_reuse</v>
> + <v>posix_file_advise() = normal | sequential | random | no_reuse
> + | will_need | dont_need</v>
> <v>Reason = ext_posix()</v>
> </type>
> <desc>
> - <p>This function allows the Operating System to perform caching
> - optimizations for accessing a file's data.</p>
> - <p>This function is available only on POSIX compliant systems.
> - For systems that are not POSIX compliant, this function has
> - no effect when invoked.</p>
> + <p><c>advise</c> can be used to announce an intention to access file
In the documentation, we include the arity when referring to a function.
Thus:
<p><c>advise/4</c> can be used to announce an intention to access file
> + data in a specific pattern in the future, thus allowing the
> + operating system to perform appropriate optimizations.</p>
> + <p>On some platforms, this function might have no effect.</p>
> </desc>
> </func>
> <func>
>
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 9:03 am |
|
|
|
Guest
|
2010/5/20 Björn Gustavsson <bgustavsson@gmail.com>
> 2010/5/19 Tuncer Ayaz <tuncer.ayaz@gmail.com>:
>
> > I would prefer the documentation to be more in line with the existing
> > text in file.xml, use the same order of advise values as in the
> > original manpage and be less specific about the effect.
>
> I also like your version better, except for a minor detail
> which I have marked below.
>
> Filipe, is this change OK for you?
>
Perfectly fine.
Thank you both for improving the documentation.
>
> > --- a/file.xml
> > +++ b/file.xml
> > @@ -69,16 +69,15 @@ time() = {{Year, Month, Day}, {Hour, Minute, Second}}
> > <v>Offset = int()</v>
> > <v>Length = int()</v>
> > <v>Advise = posix_file_advise()</v>
> > - <v>posix_file_advise() = normal | sequential | random |
> will_need
> > - | dont_need | no_reuse</v>
> > + <v>posix_file_advise() = normal | sequential | random | no_reuse
> > + | will_need | dont_need</v>
> > <v>Reason = ext_posix()</v>
> > </type>
> > <desc>
> > - <p>This function allows the Operating System to perform caching
> > - optimizations for accessing a file's data.</p>
> > - <p>This function is available only on POSIX compliant systems.
> > - For systems that are not POSIX compliant, this function has
> > - no effect when invoked.</p>
> > + <p><c>advise</c> can be used to announce an intention to access
> file
>
> In the documentation, we include the arity when referring to a function.
> Thus:
>
> <p><c>advise/4</c> can be used to announce an intention to access file
>
> > + data in a specific pattern in the future, thus allowing the
> > + operating system to perform appropriate optimizations.</p>
> > + <p>On some platforms, this function might have no effect.</p>
> > </desc>
> > </func>
> > <func>
> >
>
> --
> Björn Gustavsson, Erlang/OTP, Ericsson AB
>
--
Filipe David Manana,
fdmanana@gmail.com
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 9:03 am |
|
|
|
Guest
|
2010/5/20 Björn Gustavsson <bgustavsson@gmail.com>
> 2010/5/19 Tuncer Ayaz <tuncer.ayaz@gmail.com>:
>
> > I would prefer the documentation to be more in line with the existing
> > text in file.xml, use the same order of advise values as in the
> > original manpage and be less specific about the effect.
>
> I also like your version better, except for a minor detail
> which I have marked below.
>
> Filipe, is this change OK for you?
>
Perfectly fine.
Thank you both for improving the documentation.
>
> > --- a/file.xml
> > +++ b/file.xml
> > @@ -69,16 +69,15 @@ time() = {{Year, Month, Day}, {Hour, Minute, Second}}
> > <v>Offset = int()</v>
> > <v>Length = int()</v>
> > <v>Advise = posix_file_advise()</v>
> > - <v>posix_file_advise() = normal | sequential | random |
> will_need
> > - | dont_need | no_reuse</v>
> > + <v>posix_file_advise() = normal | sequential | random | no_reuse
> > + | will_need | dont_need</v>
> > <v>Reason = ext_posix()</v>
> > </type>
> > <desc>
> > - <p>This function allows the Operating System to perform caching
> > - optimizations for accessing a file's data.</p>
> > - <p>This function is available only on POSIX compliant systems.
> > - For systems that are not POSIX compliant, this function has
> > - no effect when invoked.</p>
> > + <p><c>advise</c> can be used to announce an intention to access
> file
>
> In the documentation, we include the arity when referring to a function.
> Thus:
>
> <p><c>advise/4</c> can be used to announce an intention to access file
>
> > + data in a specific pattern in the future, thus allowing the
> > + operating system to perform appropriate optimizations.</p>
> > + <p>On some platforms, this function might have no effect.</p>
> > </desc>
> > </func>
> > <func>
> >
>
> --
> Björn Gustavsson, Erlang/OTP, Ericsson AB
>
--
Filipe David Manana,
fdmanana@gmail.com
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 12:55 pm |
|
|
|
Guest
|
2010/5/20 Filipe David Manana <fdmanana@gmail.com>:
> Perfectly fine.
> Thank you both for improving the documentation.
OK. I have updated the branch to include the changes:
git fetch git://github.com/bjorng/otp.git fm/file-operations
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 12:55 pm |
|
|
|
Guest
|
2010/5/20 Filipe David Manana <fdmanana@gmail.com>:
> Perfectly fine.
> Thank you both for improving the documentation.
OK. I have updated the branch to include the changes:
git fetch git://github.com/bjorng/otp.git fm/file-operations
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 2:03 pm |
|
|
|
Guest
|
| On Thu, May 20, 2010 at 02:54:56PM +0200, Bj |
|
|
| Back to top |
|
| Guest |
| Posted: Thu May 20, 2010 2:04 pm |
|
|
|
Guest
|
| On Thu, May 20, 2010 at 02:54:56PM +0200, Bj |
|
|
| Back to top |
|
|
|
All times are GMT
|
|
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
|
|
|
Digg It
Del.icio.us
Reddit
Facebook
Stumble Upon
Technorati
