Erlang Mailing Lists

Author Message

<  Erlang patches mailing list  ~  Callback attribute for better definition of behaviour callb

Guest
Posted: Wed Aug 04, 2010 9:53 am Reply with quote
Guest
On Wed, Jun 30, 2010 at 4:29 PM, Raimo Niskanen
<raimo+erlang-patches@erix.ericsson.se> wrote:
>> > > The patch can be obtained with:
>> > >
>> > > git fetch git://github.com/aronisstav/otp.git callback-attr
>
> Thank you! It will be included in 'pu'.
>

The BEAM files included in several commits make this branch
a merging nightmare. I have reorganized the branch so that
there is one update of the bootstrap compiler in a separate
commit.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Guest
Posted: Wed Aug 04, 2010 9:53 am Reply with quote
Guest
On Wed, Jun 30, 2010 at 4:29 PM, Raimo Niskanen
<raimo+erlang-patches@erix.ericsson.se> wrote:
>> > > The patch can be obtained with:
>> > >
>> > > git fetch git://github.com/aronisstav/otp.git callback-attr
>
> Thank you! It will be included in 'pu'.
>

The BEAM files included in several commits make this branch
a merging nightmare. I have reorganized the branch so that
there is one update of the bootstrap compiler in a separate
commit.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Guest
Posted: Wed Aug 04, 2010 10:01 am Reply with quote
Guest
That's a painful truth which I faced not a few times while rebasing!

My reasoning was that each commit should be independent and stable on it's
own, (as it's suggested in many git guides) so I applied the various updates
on the bootstrap as they were introduced.

Thanks for the refactoring and the feedback! I'll update my branch as soon
as possible!

-- Stavros Aronis

2010/8/4 Björn Gustavsson <bgustavsson@gmail.com>

> ...

The BEAM files included in several commits make this branch
> a merging nightmare. I have reorganized the branch so that
> there is one update of the bootstrap compiler in a separate
> commit.
>
> --
> Björn Gustavsson, Erlang/OTP, Ericsson AB
>


Post received from mailinglist
Guest
Posted: Wed Aug 04, 2010 10:01 am Reply with quote
Guest
That's a painful truth which I faced not a few times while rebasing!

My reasoning was that each commit should be independent and stable on it's
own, (as it's suggested in many git guides) so I applied the various updates
on the bootstrap as they were introduced.

Thanks for the refactoring and the feedback! I'll update my branch as soon
as possible!

-- Stavros Aronis

2010/8/4 Björn Gustavsson <bgustavsson@gmail.com>

> ...

The BEAM files included in several commits make this branch
> a merging nightmare. I have reorganized the branch so that
> there is one update of the bootstrap compiler in a separate
> commit.
>
> --
> Björn Gustavsson, Erlang/OTP, Ericsson AB
>


Post received from mailinglist
Guest
Posted: Wed Aug 04, 2010 10:24 am Reply with quote
Guest
2010/8/4 Stavros Aronis <aronisstav@gmail.com>:

> My reasoning was that each commit should be independent and stable on it's
> own, (as it's suggested in many git guides) so I applied the various updates
> on the bootstrap as they were introduced.

Yes, that is very good advice, which I also make my
utmost to follow (so that tools like "git bisect" can be
used).

The way I did it, putting the update of the primary
bootstrap just before the commit that first will need
the new feature should still make each commit stable
on its own.

> Thanks for the refactoring and the feedback! I'll update my branch as soon
> as possible!

You are welcome.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Guest
Posted: Wed Aug 04, 2010 10:24 am Reply with quote
Guest
2010/8/4 Stavros Aronis <aronisstav@gmail.com>:

> My reasoning was that each commit should be independent and stable on it's
> own, (as it's suggested in many git guides) so I applied the various updates
> on the bootstrap as they were introduced.

Yes, that is very good advice, which I also make my
utmost to follow (so that tools like "git bisect" can be
used).

The way I did it, putting the update of the primary
bootstrap just before the commit that first will need
the new feature should still make each commit stable
on its own.

> Thanks for the refactoring and the feedback! I'll update my branch as soon
> as possible!

You are welcome.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum