Erlang Mailing Lists

Author Message

<  Erlang patches mailing list  ~  small patch for tv

Guest
Posted: Tue Dec 01, 2009 6:44 am Reply with quote
Guest
Guys, could you please have a look at this problem?
Maybe my patch is look like a workaround for a problem, but I just wanted to
point you at the existing situation.
Thanks in advance
PS: I didn't use new git-based mechanism of proposing patches, because as I
said it looks like a workaround for me and not a solution.

On Fri, Oct 23, 2009 at 10:39 AM, Dmitriy Budashny <
dmitriy.budashny@gmail.com> wrote:

> My last letter was written w/o testing for other problems, I've found there
> were other calls to lists:nthtail/2.
> I've attached a new patch file in this letter
>
> 2009/10/22 Dmitriy Budashny <dmitriy.budashny@gmail.com>
>
> Hi there
>> I've found some strange issue with tv while using stumpwm. tv was crashing
>> while I was trying to load some table, so I got such output to my console:
>> ### log begins here ###
>> =ERROR REPORT==== 22-Oct-2009::16:31:05 ===
>> Error in process <0.571.0> with exit value:
>> {function_clause,[{lists,nthtail,[6,[]]},{tv_pg_gridfcns,resize_grid,3},{tv_pg,loop,1}]}
>>
>> Internal error... restarting.
>> 10>
>> =ERROR REPORT==== 22-Oct-2009::16:31:06 ===
>> Error in process <0.578.0> with exit value:
>> {function_clause,[{lists,nthtail,[6,[]]},{tv_pg_gridfcns,resize_grid,3},{tv_pg,loop,1}]}
>>
>> Internal error... restarting.
>> ### log ends here ###
>>
>> So it continued restarting over and over again. The problem was with call
>> to lists:nthtail(6,[]) which raised exception:
>> ** exception error: no function clause matching lists:nthtail(6,[])
>> So I've made small changes to tv_pg_gridfcns.erl file. Patch attached.
>>
>> --
>> wbr, dym
>>
>
>
>
> --
> wbr, dym
>



--
wbr, dym


Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 6:44 am Reply with quote
Guest
Guys, could you please have a look at this problem?
Maybe my patch is look like a workaround for a problem, but I just wanted to
point you at the existing situation.
Thanks in advance
PS: I didn't use new git-based mechanism of proposing patches, because as I
said it looks like a workaround for me and not a solution.

On Fri, Oct 23, 2009 at 10:39 AM, Dmitriy Budashny <
dmitriy.budashny@gmail.com> wrote:

> My last letter was written w/o testing for other problems, I've found there
> were other calls to lists:nthtail/2.
> I've attached a new patch file in this letter
>
> 2009/10/22 Dmitriy Budashny <dmitriy.budashny@gmail.com>
>
> Hi there
>> I've found some strange issue with tv while using stumpwm. tv was crashing
>> while I was trying to load some table, so I got such output to my console:
>> ### log begins here ###
>> =ERROR REPORT==== 22-Oct-2009::16:31:05 ===
>> Error in process <0.571.0> with exit value:
>> {function_clause,[{lists,nthtail,[6,[]]},{tv_pg_gridfcns,resize_grid,3},{tv_pg,loop,1}]}
>>
>> Internal error... restarting.
>> 10>
>> =ERROR REPORT==== 22-Oct-2009::16:31:06 ===
>> Error in process <0.578.0> with exit value:
>> {function_clause,[{lists,nthtail,[6,[]]},{tv_pg_gridfcns,resize_grid,3},{tv_pg,loop,1}]}
>>
>> Internal error... restarting.
>> ### log ends here ###
>>
>> So it continued restarting over and over again. The problem was with call
>> to lists:nthtail(6,[]) which raised exception:
>> ** exception error: no function clause matching lists:nthtail(6,[])
>> So I've made small changes to tv_pg_gridfcns.erl file. Patch attached.
>>
>> --
>> wbr, dym
>>
>
>
>
> --
> wbr, dym
>



--
wbr, dym


Post received from mailinglist
maxlapshin
Posted: Tue Dec 01, 2009 7:00 am Reply with quote
User Joined: 15 Sep 2009 Posts: 159
On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny
<dmitriy.budashny@gmail.com> wrote:
> PS: I didn't use new git-based mechanism of proposing patches, because as I
> said it looks like a workaround for me and not a solution.

Dmitry, how do you think, erlang team, will apply your patch, if they
have already migrated to git?
Maybe it is the time to stop using CVS?

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
View user's profile Send private message Send e-mail
maxlapshin
Posted: Tue Dec 01, 2009 7:00 am Reply with quote
User Joined: 15 Sep 2009 Posts: 159
On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny
<dmitriy.budashny@gmail.com> wrote:
> PS: I didn't use new git-based mechanism of proposing patches, because as I
> said it looks like a workaround for me and not a solution.

Dmitry, how do you think, erlang team, will apply your patch, if they
have already migrated to git?
Maybe it is the time to stop using CVS?

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
View user's profile Send private message Send e-mail
Guest
Posted: Tue Dec 01, 2009 7:44 am Reply with quote
Guest
On Tue, Dec 1, 2009 at 9:00 AM, Max Lapshin <max.lapshin@gmail.com> wrote:

> On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny
> <dmitriy.budashny@gmail.com> wrote:
> > PS: I didn't use new git-based mechanism of proposing patches, because as
> I
> > said it looks like a workaround for me and not a solution.
>
> Dmitry, how do you think, erlang team, will apply your patch, if they
> have already migrated to git?
>
Actually I didn't see any changes were done on the exact file, so I don't
see any difference to pull it from git or to take it from the released
archive file. (correct me if I've mistaken)
Btw, yes I can branch from git, made a patch there, send a link. But
1) I didn't see any attention before, so I don't know if the other mail will
be not directing towards /dev/null
2) I think about my patch as a workaround for problem which points to the
exact places in code which do the harm
And answer to your question: no I don't think so. But if I will see any
words about `redo it in git`, I'll do so w/o any probs.


> Maybe it is the time to stop using CVS?
>

Ehhh, is there any context for such a question?
--
wbr, dym


Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 7:44 am Reply with quote
Guest
On Tue, Dec 1, 2009 at 9:00 AM, Max Lapshin <max.lapshin@gmail.com> wrote:

> On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny
> <dmitriy.budashny@gmail.com> wrote:
> > PS: I didn't use new git-based mechanism of proposing patches, because as
> I
> > said it looks like a workaround for me and not a solution.
>
> Dmitry, how do you think, erlang team, will apply your patch, if they
> have already migrated to git?
>
Actually I didn't see any changes were done on the exact file, so I don't
see any difference to pull it from git or to take it from the released
archive file. (correct me if I've mistaken)
Btw, yes I can branch from git, made a patch there, send a link. But
1) I didn't see any attention before, so I don't know if the other mail will
be not directing towards /dev/null
2) I think about my patch as a workaround for problem which points to the
exact places in code which do the harm
And answer to your question: no I don't think so. But if I will see any
words about `redo it in git`, I'll do so w/o any probs.


> Maybe it is the time to stop using CVS?
>

Ehhh, is there any context for such a question?
--
wbr, dym


Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 7:53 am Reply with quote
Guest
I have seen your email but havn't had time to look at the patch yet, sorry.
Git-patches are preferred in the future, it's simpler and we hopefully
won't forget them,
but even with git-patches we must have time to take a look them.

/Dan

On Tue, Dec 1, 2009 at 8:44 AM, Dmitriy Budashny
<dmitriy.budashny@gmail.com> wrote:
> On Tue, Dec 1, 2009 at 9:00 AM, Max Lapshin <max.lapshin@gmail.com> wrote:
>
>> On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny
>> <dmitriy.budashny@gmail.com> wrote:
>> > PS: I didn't use new git-based mechanism of proposing patches, because as
>> I
>> > said it looks like a workaround for me and not a solution.
>>
>> Dmitry, how do you think, erlang team, will apply your patch, if they
>> have already migrated to git?
>>
> Actually I didn't see any changes were done on the exact file, so I don't
> see any difference to pull it from git or to take it from the released
> archive file. (correct me if I've mistaken)
> Btw, yes I can branch from git, made a patch there, send a link. But
> 1) I didn't see any attention before, so I don't know if the other mail will
> be not directing towards /dev/null
> 2) I think about my patch as a workaround for problem which points to the
> exact places in code which do the harm
> And answer to your question: no I don't think so. But if I will see any
> words about `redo it in git`, I'll do so w/o any probs.
>
>
>> Maybe it is the time to stop using CVS?
>>
>
> Ehhh, is there any context for such a question?
> --
> wbr, dym
>

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 7:53 am Reply with quote
Guest
I have seen your email but havn't had time to look at the patch yet, sorry.
Git-patches are preferred in the future, it's simpler and we hopefully
won't forget them,
but even with git-patches we must have time to take a look them.

/Dan

On Tue, Dec 1, 2009 at 8:44 AM, Dmitriy Budashny
<dmitriy.budashny@gmail.com> wrote:
> On Tue, Dec 1, 2009 at 9:00 AM, Max Lapshin <max.lapshin@gmail.com> wrote:
>
>> On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny
>> <dmitriy.budashny@gmail.com> wrote:
>> > PS: I didn't use new git-based mechanism of proposing patches, because as
>> I
>> > said it looks like a workaround for me and not a solution.
>>
>> Dmitry, how do you think, erlang team, will apply your patch, if they
>> have already migrated to git?
>>
> Actually I didn't see any changes were done on the exact file, so I don't
> see any difference to pull it from git or to take it from the released
> archive file. (correct me if I've mistaken)
> Btw, yes I can branch from git, made a patch there, send a link. But
> 1) I didn't see any attention before, so I don't know if the other mail will
> be not directing towards /dev/null
> 2) I think about my patch as a workaround for problem which points to the
> exact places in code which do the harm
> And answer to your question: no I don't think so. But if I will see any
> words about `redo it in git`, I'll do so w/o any probs.
>
>
>> Maybe it is the time to stop using CVS?
>>
>
> Ehhh, is there any context for such a question?
> --
> wbr, dym
>

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 10:27 am Reply with quote
Guest
On Tue, Dec 1, 2009 at 8:44 AM, Dmitriy Budashny
<dmitriy.budashny@gmail.com> wrote:
> On Tue, Dec 1, 2009 at 9:00 AM, Max Lapshin <max.lapshin@gmail.com> wrote:
>
>> On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny

> Btw, yes I can branch from git, made a patch there, send a link. But
> 1) I didn't see any attention before, so I don't know if the other mail will
> be not directing towards /dev/null

Except for obviously wrong or inappropriate patches, we will include
everything in the 'pu' branch. See
http://wiki.github.com/erlang/otp/submitting-patches

> 2) I think about my patch as a workaround for problem which points to the
> exact places in code which do the harm

By submitting in your patch in git, it will be much easier for everyone
else to testing your patch and the patch will be listed in "What's cooking in
erlang/otp", so it will not be forgotten.

If you also could provide some instructions how to reproduce the problem,
it would help to find the real problem (please put all information in the commit
message)

> And answer to your question: no I don't think so. But if I will see any
> words about `redo it in git`, I'll do so w/o any probs.

Please redo it in git. Smile

Actually, I would suggest copying nthtail/2 from lists and modify it
like this (NOT TESTED):

safe_nthtail(_, []) -> [];
safe_nthtail(1, [_|T]) -> T;
safe_nthtail(N, [_|T]) when N > 1 ->
safe_nthtail(N - 1, T);
safe_nthtail(0, L) when is_list(L) -> L.

rather than traversing the list twice.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 10:27 am Reply with quote
Guest
On Tue, Dec 1, 2009 at 8:44 AM, Dmitriy Budashny
<dmitriy.budashny@gmail.com> wrote:
> On Tue, Dec 1, 2009 at 9:00 AM, Max Lapshin <max.lapshin@gmail.com> wrote:
>
>> On Tue, Dec 1, 2009 at 9:43 AM, Dmitriy Budashny

> Btw, yes I can branch from git, made a patch there, send a link. But
> 1) I didn't see any attention before, so I don't know if the other mail will
> be not directing towards /dev/null

Except for obviously wrong or inappropriate patches, we will include
everything in the 'pu' branch. See
http://wiki.github.com/erlang/otp/submitting-patches

> 2) I think about my patch as a workaround for problem which points to the
> exact places in code which do the harm

By submitting in your patch in git, it will be much easier for everyone
else to testing your patch and the patch will be listed in "What's cooking in
erlang/otp", so it will not be forgotten.

If you also could provide some instructions how to reproduce the problem,
it would help to find the real problem (please put all information in the commit
message)

> And answer to your question: no I don't think so. But if I will see any
> words about `redo it in git`, I'll do so w/o any probs.

Please redo it in git. Smile

Actually, I would suggest copying nthtail/2 from lists and modify it
like this (NOT TESTED):

safe_nthtail(_, []) -> [];
safe_nthtail(1, [_|T]) -> T;
safe_nthtail(N, [_|T]) when N > 1 ->
safe_nthtail(N - 1, T);
safe_nthtail(0, L) when is_list(L) -> L.

rather than traversing the list twice.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 1:21 pm Reply with quote
Guest
2009/12/1 Dmitriy Budashny <dmitriy.budashny@gmail.com>:
> 2009/12/1 Björn Gustavsson <bgustavsson@gmail.com>
>
> git fetch git://github.com/dym/otp.git tv_nthtail_fix
>

Thanks! Pulled and included in the 'pu' branch.

I cannot reproduce the problem. I assume it has something
to do with your window manager.

We'll let it in cook in the 'pu' branch for a while.

Unless someone finds any problem with the fix or a better
way to correct the bug, I think we should include this fix
in the R13B04 release.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
Guest
Posted: Tue Dec 01, 2009 1:21 pm Reply with quote
Guest
2009/12/1 Dmitriy Budashny <dmitriy.budashny@gmail.com>:
> 2009/12/1 Björn Gustavsson <bgustavsson@gmail.com>
>
> git fetch git://github.com/dym/otp.git tv_nthtail_fix
>

Thanks! Pulled and included in the 'pu' branch.

I cannot reproduce the problem. I assume it has something
to do with your window manager.

We'll let it in cook in the 'pu' branch for a while.

Unless someone finds any problem with the fix or a better
way to correct the bug, I think we should include this fix
in the R13B04 release.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches mailing list. See http://www.erlang.org/faq.html
erlang-patches (at) erlang.org

Post received from mailinglist
ioven
Posted: Fri Mar 23, 2012 6:26 am Reply with quote
Joined: 23 Mar 2012 Posts: 8 Location: new york
Not many cloaking is finished having detrimental motive. Lots of years before, When i worked with an exceptionally substantial comparison-shopping web page, encouraging this overseas designs connected with it is web-sites crank out far more targeted visitors. On the list of useful factors When i recognized promptly seemed to be so it seemed to be cloaking its very own property websites! Rather than the type of which mankind discovered having merchandise, pics in addition to advertising and marketing content, this cloaked type seemed to be an effective directory inbound links to help the vast majority of different types which is services received merchandise.

When When i added this trouble to help light-weight, the item turned out which the electrical engineer in charge received knowingly performed that. He / she idea it becomes far more useful to yahoo and google to provide an effective directory inbound links to enable them to obtain the information in the exact location. He / she decided not to possibly are aware that cloaking seemed to be up against the policies and may even find the web-sites suspended!
Cheap Soccer Jerseys
Custom Soccer Jerseys
Air Jordan Shoes
Beats Headphones
Beats By Dr Dre
Monster Beats
Beats By Dr Dre
Monster Headphones
Monster Beats
dr dre headphones
Dr Dre Beats
Beats Headphones
Dre Beats
View user's profile Send private message
wuji
Posted: Tue Sep 18, 2012 6:37 am Reply with quote
User Joined: 10 Aug 2012 Posts: 654
the expense of our villain, Rex, and not at the the cheap authentic jordans the expense of those suffering from the disease."The joke, "From
man to another, I hope you get Lou Gehrig's disease," disease," cheap replica designer *beep* disease," shocked movie-going patients and advocates, who say it crossed
line."I didn't expect to go to a movie and sit sit cheap authentic jordans sit with an audience laughing at the expense of people
ALS," said Randy Pipkin, who was diagnosed in 2005. "I "I [h4]replica designer bags for sale[/h4] "I think the message this film sends out is a
slap in the face to people dying from this horrific horrific [h4]authentic jordans[/h4] horrific disease."Lou Gehrig's disease, also known as ALS, progressively robs
of their ability to move, speak, eat and breathe. There There authentic jordans There is currently no cure.The punch line prompted an online
urging MacFarlane to apologize and donate $200,000 of the movie's movie's replica designer *beep* movie's proceedings to ALS research."The thing that Mr. MacFarlane and
fail to realize is that ALS sufferers are some of of [h4]cheap authentic jordans[/h4] of the kindest, compassionate, thoughtful, and loving individuals one will
View user's profile Send private message

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum