| Author |
Message |
|
| Guest |
 Posted: Thu Apr 08, 2010 3:48 am |
 |
|
|
Guest
|
Hi,
system_info(procs) is currently reporting a same value for both
"OldHeap" and "OldHeap unsed".
This is a patch for erts/emulator/beam/break.c to report
"OLD_HEND(p) - OLD_HTOP(p)"
instead of
"OLD_HEND(p) - OLD_HEAP(p)"
for "OldHeap unsed".
git fetch git://github.com/kinogmt/otp.git old_heap_unused
kino
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu Apr 08, 2010 3:48 am |
|
|
|
Guest
|
Hi,
system_info(procs) is currently reporting a same value for both
"OldHeap" and "OldHeap unsed".
This is a patch for erts/emulator/beam/break.c to report
"OLD_HEND(p) - OLD_HTOP(p)"
instead of
"OLD_HEND(p) - OLD_HEAP(p)"
for "OldHeap unsed".
git fetch git://github.com/kinogmt/otp.git old_heap_unused
kino
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu Apr 08, 2010 7:54 am |
|
|
|
Guest
|
On Thu, Apr 8, 2010 at 5:48 AM, satoshi kinoshita <kino@geminimobile.com> wrote:
> system_info(procs) is currently reporting a same value for both
> "OldHeap" and "OldHeap unsed".
> This is a patch for erts/emulator/beam/break.c to report
> "OLD_HEND(p) - OLD_HTOP(p)"
> instead of
> "OLD_HEND(p) - OLD_HEAP(p)"
> for "OldHeap unsed".
>
> git fetch git://github.com/kinogmt/otp.git old_heap_unused
>
Thanks! The patch itself looks good, but we would prefer
to have a complete author name. Is OK to change the
author identification to "Satoshi Kinoshito <kino@geminimobile.com>"?
Also, I would like more information in the commit message,
for instance like this:
system_info(procs): Fix the value for "OldHeap unused"
The value for "OldHeap unused" in the output of
erlang:system_info(procs) and in crash dumps, was incorrectly
calculated as the size of the entire old heap.
If you approve the changes above, I can do the changes for you.
You don't have to re-submit the patch.
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu Apr 08, 2010 7:55 am |
|
|
|
Guest
|
On Thu, Apr 8, 2010 at 5:48 AM, satoshi kinoshita <kino@geminimobile.com> wrote:
> system_info(procs) is currently reporting a same value for both
> "OldHeap" and "OldHeap unsed".
> This is a patch for erts/emulator/beam/break.c to report
> "OLD_HEND(p) - OLD_HTOP(p)"
> instead of
> "OLD_HEND(p) - OLD_HEAP(p)"
> for "OldHeap unsed".
>
> git fetch git://github.com/kinogmt/otp.git old_heap_unused
>
Thanks! The patch itself looks good, but we would prefer
to have a complete author name. Is OK to change the
author identification to "Satoshi Kinoshito <kino@geminimobile.com>"?
Also, I would like more information in the commit message,
for instance like this:
system_info(procs): Fix the value for "OldHeap unused"
The value for "OldHeap unused" in the output of
erlang:system_info(procs) and in crash dumps, was incorrectly
calculated as the size of the entire old heap.
If you approve the changes above, I can do the changes for you.
You don't have to re-submit the patch.
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu Apr 08, 2010 8:02 am |
|
|
|
Guest
|
At Thu, 8 Apr 2010 09:54:17 +0200,
Björn Gustavsson wrote:
>
> On Thu, Apr 8, 2010 at 5:48 AM, satoshi kinoshita <kino@geminimobile.com> wrote:
>
> > system_info(procs) is currently reporting a same value for both
> > "OldHeap" and "OldHeap unsed".
> > This is a patch for erts/emulator/beam/break.c to report
> > "OLD_HEND(p) - OLD_HTOP(p)"
> > instead of
> > "OLD_HEND(p) - OLD_HEAP(p)"
> > for "OldHeap unsed".
> >
> > git fetch git://github.com/kinogmt/otp.git old_heap_unused
> >
>
> Thanks! The patch itself looks good, but we would prefer
> to have a complete author name. Is OK to change the
> author identification to "Satoshi Kinoshito <kino@geminimobile.com>"?
Sure.
Please go ahead fix it.
(uh, my famylyname is "Kinoshita" though:)
thanks,
kino
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu Apr 08, 2010 8:02 am |
|
|
|
Guest
|
At Thu, 8 Apr 2010 09:54:17 +0200,
Björn Gustavsson wrote:
>
> On Thu, Apr 8, 2010 at 5:48 AM, satoshi kinoshita <kino@geminimobile.com> wrote:
>
> > system_info(procs) is currently reporting a same value for both
> > "OldHeap" and "OldHeap unsed".
> > This is a patch for erts/emulator/beam/break.c to report
> > "OLD_HEND(p) - OLD_HTOP(p)"
> > instead of
> > "OLD_HEND(p) - OLD_HEAP(p)"
> > for "OldHeap unsed".
> >
> > git fetch git://github.com/kinogmt/otp.git old_heap_unused
> >
>
> Thanks! The patch itself looks good, but we would prefer
> to have a complete author name. Is OK to change the
> author identification to "Satoshi Kinoshito <kino@geminimobile.com>"?
Sure.
Please go ahead fix it.
(uh, my famylyname is "Kinoshita" though:)
thanks,
kino
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu Apr 08, 2010 8:13 am |
|
|
|
Guest
|
2010/4/8 satoshi kinoshita <kino@geminimobile.com>:
> Please go ahead fix it.
> (uh, my famylyname is "Kinoshita" though:)
Sorry for getting it wrong. I'll fix that and include your branch in 'pu'.
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
| Guest |
| Posted: Thu Apr 08, 2010 8:13 am |
|
|
|
Guest
|
2010/4/8 satoshi kinoshita <kino@geminimobile.com>:
> Please go ahead fix it.
> (uh, my famylyname is "Kinoshita" though:)
Sorry for getting it wrong. I'll fix that and include your branch in 'pu'.
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org
Post received from mailinglist |
|
|
| Back to top |
|
|
|
Digg It
Del.icio.us
Reddit
Facebook
Stumble Upon
Technorati
