Erlang Mailing Lists

Author Message

<  Erlang patches mailing list  ~  how to properly submit a patch

Guest
Posted: Thu Apr 22, 2010 10:58 pm Reply with quote
Guest
Hello,

I have just made some modifs to prim_file.erl.

In order to rebuild the preloaded modules (for testing my changes), I ran
"./otp_build update_preloaded" which not only rebuilds the preloaded modules
but also commits plenty of things into my git repo.

Now, I want to submit a patch with my modifs, should I send a patch that
includes the changes committed by "./otp_build update_preloaded", or only
the really important diff?

thanks

--
Filipe David Manana,
fdmanana@gmail.com

"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."


Post received from mailinglist
Guest
Posted: Thu Apr 22, 2010 10:59 pm Reply with quote
Guest
Hello,

I have just made some modifs to prim_file.erl.

In order to rebuild the preloaded modules (for testing my changes), I ran
"./otp_build update_preloaded" which not only rebuilds the preloaded modules
but also commits plenty of things into my git repo.

Now, I want to submit a patch with my modifs, should I send a patch that
includes the changes committed by "./otp_build update_preloaded", or only
the really important diff?

thanks

--
Filipe David Manana,
fdmanana@gmail.com

"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."


Post received from mailinglist

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum