Erlang Mailing Lists
Author Message

<  Erlang patches mailing list  ~  Possible BEAM compiler patch
Guest
Posted: Sun Jul 25, 2010 1:23 pm Reply with quote
Guest
On Thu, Jun 24, 2010 at 12:49 PM, Martti Kuparinen
<martti.kuparinen@iki.fi> wrote:
> Hi,
>
> The NetBSD pkgsrc has this patch (pkgsrc/lang/erlang/patches/patch-ah)
>
>
> --- lib/compiler/src/v3_codegen.erl.orig        2008-02-05
> 08:37:35.000000000 -0
> 500
> +++ lib/compiler/src/v3_codegen.erl
> @@ -1481,6 +1481,8 @@ cg_binary_size_1([], Bits, Acc) ->
>     Sizes = filter(fun({_,{integer,0}}) -> false;
>                      (_) -> true end, Sizes0),
>     case Sizes of
> +       [] ->
> +           {bs_init2,[{integer,0}]};
>        [{1,_}|_] ->
>            {bs_init_bits,cg_binary_bytes_to_bits(Sizes, [])};
>        [{8,_}|_] ->
>
>
> but I don't know it that makes any sense or not. Could someone from the
> compiler team look at this and say if I should nuke this or submit a
> proper patch request so it can be included in the pu branch...
>

Thanks! It makes sense. Please include a test case in the patch
to ensure that the new clause will be tested.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Back to top
Guest
Posted: Sun Jul 25, 2010 1:24 pm Reply with quote
Guest
On Thu, Jun 24, 2010 at 12:49 PM, Martti Kuparinen
<martti.kuparinen@iki.fi> wrote:
> Hi,
>
> The NetBSD pkgsrc has this patch (pkgsrc/lang/erlang/patches/patch-ah)
>
>
> --- lib/compiler/src/v3_codegen.erl.orig        2008-02-05
> 08:37:35.000000000 -0
> 500
> +++ lib/compiler/src/v3_codegen.erl
> @@ -1481,6 +1481,8 @@ cg_binary_size_1([], Bits, Acc) ->
>     Sizes = filter(fun({_,{integer,0}}) -> false;
>                      (_) -> true end, Sizes0),
>     case Sizes of
> +       [] ->
> +           {bs_init2,[{integer,0}]};
>        [{1,_}|_] ->
>            {bs_init_bits,cg_binary_bytes_to_bits(Sizes, [])};
>        [{8,_}|_] ->
>
>
> but I don't know it that makes any sense or not. Could someone from the
> compiler team look at this and say if I should nuke this or submit a
> proper patch request so it can be included in the pu branch...
>

Thanks! It makes sense. Please include a test case in the patch
to ensure that the new clause will be tested.

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Back to top

Display posts from previous:  

All times are GMT
View next topic
View previous topic
Page 1 of 1
Erlang Forum - Trap Exit Forum Index  ~  Erlang patches mailing list
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
Hosted by Erlang Solutions    |    Powered by phpBB and NoseBleed v1.14