Erlang Mailing Lists
Author Message

<  Ejabberd mailing list  ~  epoll - 11B-r1 modified patch
Guest
Posted: Tue Sep 05, 2006 2:49 pm Reply with quote
Guest
Hi there,
I have recently modified the patch so it cleanly applies to the recent
11B-r1 release of Erlang.

I have not had a chance to fully test, but I believe the only changes
have been the allocation of memory and some minor changes to the
configure.in file.

The only test that has been run is a 10000 users Tsung test on ejabberd,
and the load looked a lot better Smile

I hope this patch is correct!

Cheers,
Daniel.


Post recived from mailinglist
Back to top
Guest
Posted: Tue Sep 05, 2006 3:28 pm Reply with quote
Guest
Hi,
Back to top
Guest
Posted: Tue Sep 05, 2006 3:44 pm Reply with quote
Guest
On Tue, 5 Sep 2006, Daniel Bartlett wrote:

> --- erts/acconfig.h 2005-06-21 09:37:40.000000000 -0700
> +++ erts/acconfig.h 2006-03-10 15:55:12.000000000 -0800
> @@ -224,7 +227,7 @@
>
> #if !defined(USE_SELECT)
> # if defined(ENABLE_KERNEL_POLL)
> -# if defined(HAVE_SYS_DEVPOLL_H) || defined(HAVE_LINUX_KPOLL_H) || defined(HAVE_SYS_EVENT_H)
> +# if defined(HAVE_SYS_DEVPOLL_H) || defined(HAVE_LINUX_KPOLL_H) || defined(HAVE_SYS_EVENT_H) || defined(HAVE_LINUX_KPOLL_H)
> # define USE_KERNEL_POLL
> # endif
> # endif

Shouldn't the addition be HAVE_LINUX_EPOLL_H? (E not K)

Tony.
--
f.a.n.finch <dot@dotat.at> http://dotat.at/
FISHER: WEST OR NORTHWEST 4 OR 5 BECOMING VARIABLE 3 OR 4. FAIR. MODERATE OR
GOOD.
_______________________________________________
ejabberd mailing list
ejabberd@jabber.ru
http://lists.jabber.ru/mailman/listinfo/ejabberd
Post recived from mailinglist
Back to top
Guest
Posted: Tue Sep 05, 2006 3:53 pm Reply with quote
Guest
Hi,

Tony Finch wrote:
> On Tue, 5 Sep 2006, Daniel Bartlett wrote:
>
>> --- erts/acconfig.h 2005-06-21 09:37:40.000000000 -0700
>> +++ erts/acconfig.h 2006-03-10 15:55:12.000000000 -0800
>> @@ -224,7 +227,7 @@
>>
>> #if !defined(USE_SELECT)
>> # if defined(ENABLE_KERNEL_POLL)
>> -# if defined(HAVE_SYS_DEVPOLL_H) || defined(HAVE_LINUX_KPOLL_H) || defined(HAVE_SYS_EVENT_H)
>> +# if defined(HAVE_SYS_DEVPOLL_H) || defined(HAVE_LINUX_KPOLL_H) || defined(HAVE_SYS_EVENT_H) || defined(HAVE_LINUX_KPOLL_H)
>> # define USE_KERNEL_POLL
>> # endif
>> # endif
>
> Shouldn't the addition be HAVE_LINUX_EPOLL_H? (E not K)

I'm not 100% on this but probably, in the comments of the patch there
are some notes about being lazy and setting KPOLL in order to save too
much code change. But in this case it should probably be EPOLL.

I'll look into it.

>
> Tony.

Cheers,
Dan.
_______________________________________________
ejabberd mailing list
ejabberd@jabber.ru
http://lists.jabber.ru/mailman/listinfo/ejabberd
Post recived from mailinglist
Back to top
Guest
Posted: Tue Sep 05, 2006 4:13 pm Reply with quote
Guest
Hello Daniel,

* Daniel Bartlett <dan@f-box.org> [2006-09-05 16:49:28 +0200]:

> Hi there,
> I have recently modified the patch so it cleanly applies to the recent
> 11B-r1 release of Erlang.

This patch can be applied to erlang R11.

The only drawback users should be aware of is that it is not possible to
enable kernel polling and SMP at the same time.
We have started working on a patch like this but it is much more
difficult unfortunately.
For now, the only option is to choose between SMP and polling.

Cheers,

--
Micka
Back to top

Display posts from previous:  

All times are GMT
View next topic
View previous topic
Page 1 of 1
Erlang Forum - Trap Exit Forum Index  ~  Ejabberd mailing list
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum
Hosted by Erlang Solutions    |    Powered by phpBB and NoseBleed v1.14