Erlang/OTP Forums

Author Message

<  Yaws mailing list  ~  Patchs on soap support: configurations and call with prefix.

Guest
Posted: Fri Nov 20, 2009 12:36 pm Reply with quote
Guest
Eric Liang wrote:
> Hi all,
> Last week , I talked about soap on yaws with Steve Vinoski. He
> recommended some valuable articles to read and suggested just using http
> instead of soap. I do agree with him in some aspects, but still can't
> avoid soap. So, it's still necessary to make better support on soap by
> yaws, IMO.

Patch look good to me - some comments.

1. Maybe a good idea to keep soap_srv:start_link/0 if people are
calling this function explicitly - which I think they are.


2. Please add some docs to man/yaws.conf.5 describing how to
use the feature.


I don't like adding stuff to neither gconf nor sconf since these
structs get passed around a lot among processes - i.e copied.
OTOH there is already so much cruft there so adding even more can't harm.
It's time to clean up both these records moving some of the more
exotic features into a subrecord.

So - all in all - nice work, but please comment or fix (1) and do (2)


Thanks

/klacke


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post received from mailinglist
start2046
Posted: Fri Nov 20, 2009 3:56 pm Reply with quote
User Joined: 28 Oct 2009 Posts: 19
Claes Wikström wrote:
> Eric Liang wrote:
>> Hi all,
>> Last week , I talked about soap on yaws with Steve Vinoski. He
>> recommended some valuable articles to read and suggested just using
>> http instead of soap. I do agree with him in some aspects, but still
>> can't avoid soap. So, it's still necessary to make better support on
>> soap by yaws, IMO.
>
> Patch look good to me - some comments.
>
> 1. Maybe a good idea to keep soap_srv:start_link/0 if people are
> calling this function explicitly - which I think they are.
Thanks, Claes.
I agree with you, this is something I missed. This is fixed by patch 3
(follow the number of last mail), please check it.

>
>
> 2. Please add some docs to man/yaws.conf.5 describing how to
> use the feature.
>
I've tried to do this( see patch 4), please check it,too.

>
> I don't like adding stuff to neither gconf nor sconf since these
> structs get passed around a lot among processes - i.e copied.
> OTOH there is already so much cruft there so adding even more can't harm.
> It's time to clean up both these records moving some of the more
> exotic features into a subrecord.
Enlightened by yaws_config:soft_setconf() , you could consider some
plug-in style configuration, which will allow some external services and
their configurations to be installed , modified and uninstalled on the
fly. And the idea is unshaped, it's just a suggestion, HTH. Smile

Eric
>
> So - all in all - nice work, but please comment or fix (1) and do (2)
>
>
> Thanks
>
> /klacke
>



Post received from mailinglist
View user's profile Send private message Send e-mail
Guest
Posted: Mon Nov 23, 2009 9:31 am Reply with quote
Guest
Ok - all good, applied and pushed.

Thanks

/klacke

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post received from mailinglist

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum