Erlang/OTP Forums

Author Message

<  Erlang patches mailing list  ~  auth

Guest
Posted: Wed Jun 09, 2010 8:48 am Reply with quote
Guest
Fix some types and specs:

git fetch git://github.com/kostis/otp.git auth-specs

Kostis

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Guest
Posted: Wed Jun 09, 2010 8:49 am Reply with quote
Guest
Fix some types and specs:

git fetch git://github.com/kostis/otp.git auth-specs

Kostis

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Guest
Posted: Wed Jun 09, 2010 10:38 am Reply with quote
Guest
2010/6/9 Kostis Sagonas <kostis@cs.ntua.gr>:
> Fix some types and specs:
>
> git fetch git://github.com/kostis/otp.git auth-specs
>

We don't want actual changes mixed with minor
clean-up of the indentation. *If* indentation is to
be cleaned up (I don't recommend such clean-ups
unless the indentation is severely messed up),
it should be made in a separate commit.
(Reason: for ease of reviewing and for ease of
browsing and understanding the history.)

I have removed the part of the patch that changes
the indentation. Your branch also contains merge
commits, which will cause problems, so I have
rebased your commit on top of the current 'dev'.

The revised branch (suitable for inclusion in 'pu')
can be found here:

http://github.com/bjorng/otp/commit/1c511359ba2556fdf357d778d7e20b5468db97d8

git fetch git://github.com/bjorng/otp.git ks/auth-specs

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Guest
Posted: Wed Jun 09, 2010 10:38 am Reply with quote
Guest
2010/6/9 Kostis Sagonas <kostis@cs.ntua.gr>:
> Fix some types and specs:
>
> git fetch git://github.com/kostis/otp.git auth-specs
>

We don't want actual changes mixed with minor
clean-up of the indentation. *If* indentation is to
be cleaned up (I don't recommend such clean-ups
unless the indentation is severely messed up),
it should be made in a separate commit.
(Reason: for ease of reviewing and for ease of
browsing and understanding the history.)

I have removed the part of the patch that changes
the indentation. Your branch also contains merge
commits, which will cause problems, so I have
rebased your commit on top of the current 'dev'.

The revised branch (suitable for inclusion in 'pu')
can be found here:

http://github.com/bjorng/otp/commit/1c511359ba2556fdf357d778d7e20b5468db97d8

git fetch git://github.com/bjorng/otp.git ks/auth-specs

--
Björn Gustavsson, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum