Erlang/OTP Forums

Author Message

<  Erlang patches mailing list  ~  patch: Allow a user_defined function to wrap mnesia_schema:m

uwiger
Posted: Tue Jun 01, 2010 2:19 pm Reply with quote
User Joined: 03 Jul 2006 Posts: 604 Location: Sweden
What is the easiest way to address it?

The debug printout:
Line 2663 in
http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
should be deleted (I've not seen any other debug printouts)

The crash:
Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.

I could resubmit, but my git fu is still low enough that I'm
likely to make a mess of things without detailed instructions. Smile

I have done the above and tested with four nodes (it did in fact
crash before; now it doesn't).

BR,
Ulf W

Dan Gudmundsson wrote:
> There are debug printouts left.
> Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
>
> /Dan
>
> 2010/5/10 Bj
View user's profile Send private message Visit poster's website
uwiger
Posted: Tue Jun 01, 2010 2:20 pm Reply with quote
User Joined: 03 Jul 2006 Posts: 604 Location: Sweden
What is the easiest way to address it?

The debug printout:
Line 2663 in
http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
should be deleted (I've not seen any other debug printouts)

The crash:
Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.

I could resubmit, but my git fu is still low enough that I'm
likely to make a mess of things without detailed instructions. Smile

I have done the above and tested with four nodes (it did in fact
crash before; now it doesn't).

BR,
Ulf W

Dan Gudmundsson wrote:
> There are debug printouts left.
> Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
>
> /Dan
>
> 2010/5/10 Bj
View user's profile Send private message Visit poster's website
Guest
Posted: Tue Jun 01, 2010 3:58 pm Reply with quote
Guest
On Tue, Jun 01, 2010 at 04:19:36PM +0200, Ulf Wiger wrote:
>
> What is the easiest way to address it?
>
> The debug printout:
> Line 2663 in
> http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
> should be deleted (I've not seen any other debug printouts)
>
> The crash:
> Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.
>
> I could resubmit, but my git fu is still low enough that I'm
> likely to make a mess of things without detailed instructions. Smile

The easiest for you (and for us to follow) would be to
just keep on working on the same branch:

In your local repository (from which you pushed the local branch
schema_merge) to your github repository 'origin' (assumed).

$ git checkout schema_merge

Do the changes above.
Test it.

$ git push origin schema_merge

Send a mail to erlang-patches saying you have new commits
available with:

git fetch git://github.com/uwiger/otp.git schema_merge

>
> I have done the above and tested with four nodes (it did in fact
> crash before; now it doesn't).
>
> BR,
> Ulf W
>
> Dan Gudmundsson wrote:
> >There are debug printouts left.
> >Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
> >
> >/Dan
> >
> >2010/5/10 Bj
Guest
Posted: Tue Jun 01, 2010 3:58 pm Reply with quote
Guest
On Tue, Jun 01, 2010 at 04:19:36PM +0200, Ulf Wiger wrote:
>
> What is the easiest way to address it?
>
> The debug printout:
> Line 2663 in
> http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
> should be deleted (I've not seen any other debug printouts)
>
> The crash:
> Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.
>
> I could resubmit, but my git fu is still low enough that I'm
> likely to make a mess of things without detailed instructions. Smile

The easiest for you (and for us to follow) would be to
just keep on working on the same branch:

In your local repository (from which you pushed the local branch
schema_merge) to your github repository 'origin' (assumed).

$ git checkout schema_merge

Do the changes above.
Test it.

$ git push origin schema_merge

Send a mail to erlang-patches saying you have new commits
available with:

git fetch git://github.com/uwiger/otp.git schema_merge

>
> I have done the above and tested with four nodes (it did in fact
> crash before; now it doesn't).
>
> BR,
> Ulf W
>
> Dan Gudmundsson wrote:
> >There are debug printouts left.
> >Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
> >
> >/Dan
> >
> >2010/5/10 Bj
uwiger
Posted: Tue Jun 01, 2010 4:49 pm Reply with quote
User Joined: 03 Jul 2006 Posts: 604 Location: Sweden
I thought I'd follow your advice, but am running into

uwiger@uwiger:~/src/otp/git/mine/mnesia_merge/otp$ git push origin
schema_merge
error: Cannot access URL http://github.com/uwiger/otp.git/, return code 22
fatal: git-http-push failed

That's not an error I've seen before, and I've spent 30 minutes
trying to hunt down the cause.

It's a trivial fix, and the important test that needs to be done
is running the mnesia test suite, which I don't have access to.
Perhaps you could just do it at your end, this one time? Smile

BR,
Ulf W

On 06/01/2010 05:57 PM, Raimo Niskanen wrote:
> On Tue, Jun 01, 2010 at 04:19:36PM +0200, Ulf Wiger wrote:
>>
>> What is the easiest way to address it?
>>
>> The debug printout:
>> Line 2663 in
>> http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
>> should be deleted (I've not seen any other debug printouts)
>>
>> The crash:
>> Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.
>>
>> I could resubmit, but my git fu is still low enough that I'm
>> likely to make a mess of things without detailed instructions. Smile
>
> The easiest for you (and for us to follow) would be to
> just keep on working on the same branch:
>
> In your local repository (from which you pushed the local branch
> schema_merge) to your github repository 'origin' (assumed).
>
> $ git checkout schema_merge
>
> Do the changes above.
> Test it.
>
> $ git push origin schema_merge
>
> Send a mail to erlang-patches saying you have new commits
> available with:
>
> git fetch git://github.com/uwiger/otp.git schema_merge
>
>>
>> I have done the above and tested with four nodes (it did in fact
>> crash before; now it doesn't).
>>
>> BR,
>> Ulf W
>>
>> Dan Gudmundsson wrote:
>>> There are debug printouts left.
>>> Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
>>>
>>> /Dan
>>>
>>> 2010/5/10 Bj
View user's profile Send private message Visit poster's website
uwiger
Posted: Tue Jun 01, 2010 4:49 pm Reply with quote
User Joined: 03 Jul 2006 Posts: 604 Location: Sweden
I thought I'd follow your advice, but am running into

uwiger@uwiger:~/src/otp/git/mine/mnesia_merge/otp$ git push origin
schema_merge
error: Cannot access URL http://github.com/uwiger/otp.git/, return code 22
fatal: git-http-push failed

That's not an error I've seen before, and I've spent 30 minutes
trying to hunt down the cause.

It's a trivial fix, and the important test that needs to be done
is running the mnesia test suite, which I don't have access to.
Perhaps you could just do it at your end, this one time? Smile

BR,
Ulf W

On 06/01/2010 05:57 PM, Raimo Niskanen wrote:
> On Tue, Jun 01, 2010 at 04:19:36PM +0200, Ulf Wiger wrote:
>>
>> What is the easiest way to address it?
>>
>> The debug printout:
>> Line 2663 in
>> http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
>> should be deleted (I've not seen any other debug printouts)
>>
>> The crash:
>> Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.
>>
>> I could resubmit, but my git fu is still low enough that I'm
>> likely to make a mess of things without detailed instructions. Smile
>
> The easiest for you (and for us to follow) would be to
> just keep on working on the same branch:
>
> In your local repository (from which you pushed the local branch
> schema_merge) to your github repository 'origin' (assumed).
>
> $ git checkout schema_merge
>
> Do the changes above.
> Test it.
>
> $ git push origin schema_merge
>
> Send a mail to erlang-patches saying you have new commits
> available with:
>
> git fetch git://github.com/uwiger/otp.git schema_merge
>
>>
>> I have done the above and tested with four nodes (it did in fact
>> crash before; now it doesn't).
>>
>> BR,
>> Ulf W
>>
>> Dan Gudmundsson wrote:
>>> There are debug printouts left.
>>> Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
>>>
>>> /Dan
>>>
>>> 2010/5/10 Bj
View user's profile Send private message Visit poster's website
uwiger
Posted: Tue Jun 01, 2010 6:05 pm Reply with quote
User Joined: 03 Jul 2006 Posts: 604 Location: Sweden
git fetch git://github.com/uwiger/otp.git schema_merge

"remove debug printout and accidental variable name reuse"

http://github.com/uwiger/otp/commit/b4844311746b44e85aa49d6e7bd68703301998e0


Thanks Fredrik Thulin for helping me figure out what I did wrong.

BR,
Ulf W


On 06/01/2010 05:57 PM, Raimo Niskanen wrote:
> On Tue, Jun 01, 2010 at 04:19:36PM +0200, Ulf Wiger wrote:
>>
>> What is the easiest way to address it?
>>
>> The debug printout:
>> Line 2663 in
>> http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
>> should be deleted (I've not seen any other debug printouts)
>>
>> The crash:
>> Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.
>>
>> I could resubmit, but my git fu is still low enough that I'm
>> likely to make a mess of things without detailed instructions. Smile
>
> The easiest for you (and for us to follow) would be to
> just keep on working on the same branch:
>
> In your local repository (from which you pushed the local branch
> schema_merge) to your github repository 'origin' (assumed).
>
> $ git checkout schema_merge
>
> Do the changes above.
> Test it.
>
> $ git push origin schema_merge
>
> Send a mail to erlang-patches saying you have new commits
> available with:
>
> git fetch git://github.com/uwiger/otp.git schema_merge
>
>>
>> I have done the above and tested with four nodes (it did in fact
>> crash before; now it doesn't).
>>
>> BR,
>> Ulf W
>>
>> Dan Gudmundsson wrote:
>>> There are debug printouts left.
>>> Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
>>>
>>> /Dan
>>>
>>> 2010/5/10 Bj
View user's profile Send private message Visit poster's website
uwiger
Posted: Tue Jun 01, 2010 6:05 pm Reply with quote
User Joined: 03 Jul 2006 Posts: 604 Location: Sweden
git fetch git://github.com/uwiger/otp.git schema_merge

"remove debug printout and accidental variable name reuse"

http://github.com/uwiger/otp/commit/b4844311746b44e85aa49d6e7bd68703301998e0


Thanks Fredrik Thulin for helping me figure out what I did wrong.

BR,
Ulf W


On 06/01/2010 05:57 PM, Raimo Niskanen wrote:
> On Tue, Jun 01, 2010 at 04:19:36PM +0200, Ulf Wiger wrote:
>>
>> What is the easiest way to address it?
>>
>> The debug printout:
>> Line 2663 in
>> http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
>> should be deleted (I've not seen any other debug printouts)
>>
>> The crash:
>> Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.
>>
>> I could resubmit, but my git fu is still low enough that I'm
>> likely to make a mess of things without detailed instructions. Smile
>
> The easiest for you (and for us to follow) would be to
> just keep on working on the same branch:
>
> In your local repository (from which you pushed the local branch
> schema_merge) to your github repository 'origin' (assumed).
>
> $ git checkout schema_merge
>
> Do the changes above.
> Test it.
>
> $ git push origin schema_merge
>
> Send a mail to erlang-patches saying you have new commits
> available with:
>
> git fetch git://github.com/uwiger/otp.git schema_merge
>
>>
>> I have done the above and tested with four nodes (it did in fact
>> crash before; now it doesn't).
>>
>> BR,
>> Ulf W
>>
>> Dan Gudmundsson wrote:
>>> There are debug printouts left.
>>> Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
>>>
>>> /Dan
>>>
>>> 2010/5/10 Bj
View user's profile Send private message Visit poster's website
Guest
Posted: Wed Jun 02, 2010 6:43 am Reply with quote
Guest
On Tue, Jun 01, 2010 at 08:04:55PM +0200, Ulf Wiger wrote:
>
>
> git fetch git://github.com/uwiger/otp.git schema_merge

Thank you! It will be included in 'pu' as uw/mnesia-schema-merge.

>
> "remove debug printout and accidental variable name reuse"
>
> http://github.com/uwiger/otp/commit/b4844311746b44e85aa49d6e7bd68703301998e0
>
>
> Thanks Fredrik Thulin for helping me figure out what I did wrong.
>
> BR,
> Ulf W
>
>
:

--

/ Raimo Niskanen, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Guest
Posted: Wed Jun 02, 2010 6:44 am Reply with quote
Guest
On Tue, Jun 01, 2010 at 08:04:55PM +0200, Ulf Wiger wrote:
>
>
> git fetch git://github.com/uwiger/otp.git schema_merge

Thank you! It will be included in 'pu' as uw/mnesia-schema-merge.

>
> "remove debug printout and accidental variable name reuse"
>
> http://github.com/uwiger/otp/commit/b4844311746b44e85aa49d6e7bd68703301998e0
>
>
> Thanks Fredrik Thulin for helping me figure out what I did wrong.
>
> BR,
> Ulf W
>
>
:

--

/ Raimo Niskanen, Erlang/OTP, Ericsson AB

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum