Erlang/OTP Forums
Author Message

<  Erlang patches mailing list  ~  Fix binary:matches/2,3 when called on empty binary
Guest
Posted: Tue Nov 16, 2010 10:31 pm Reply with quote
Guest
Hello,
binary:matches doesn't always work as documented, as a consequence
binary:replace might misbehave, too.

Example:

Current behaviour:

1> binary:matches(<<>>, <<"1">>).
nomatch
2> binary:replace(<<>>, <<"1">>, <<"2">>, [global]).
** exception error: bad argument
in function binary:replace/4

New behaviour:

1> binary:matches(<<>>, <<"1">>).
[]
2> binary:replace(<<>>, <<"1">>, <<"2">>, [global]).
<<>>

Contents of the branch:
- Changing a test which assumed binary:matches should return nomatch
- Add above example of re:replace/4 as test
- Fix source to behave as documented


git fetch git://github.com/thlachmann/otp.git binary_matches_fix


Regards,
Thomas

________________________________________________________________
erlang-patches (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-patches-unsubscribe@erlang.org

Post received from mailinglist
Back to top

Display posts from previous:  

All times are GMT
View next topic
View previous topic
Page 1 of 1
Erlang Forum - Trap Exit Forum Index  ~  Erlang patches mailing list
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
Hosted by Erlang Solutions    |    Powered by phpBB and NoseBleed 1.14