Erlang/OTP Forums
Author Message

<  Erlang patches mailing list  ~  error_logger_file_h
klacke at hyber.org
Posted: Sat Feb 28, 2004 4:42 pm Reply with quote
Guest
Howdy,

I think that when doing error_logger:logfile(FileName)
the file FileName shouldn't be truncated as it is now.
In principle it makes it impossible to use the function
across restarts.

I suggest:


diff -c -r1.1.1.3 error_logger_file_h.erl
*** error_logger_file_h.erl 25 Feb 2003 08:27:23 -0000 1.1.1.3
--- error_logger_file_h.erl 28 Feb 2004 16:05:53 -0000
***************
*** 49,55 ****

init(File, PrevHandler) ->
process_flag(trap_exit, true),
! case file:open(File, write) of
{ok,Fd} ->
{ok, {Fd, File, PrevHandler}};
Error ->
--- 49,55 ----

init(File, PrevHandler) ->
process_flag(trap_exit, true),
! case file:open(File, append) of
{ok,Fd} ->
{ok, {Fd, File, PrevHandler}};
Error ->




This shouldn't break any code, and is also more intuitive.




/klacke



--
Claes Wikstrom -- Caps lock is nowhere and
http://www.hyber.org -- everything is under control


Post generated using Mail2Forum (http://m2f.sourceforge.net)
Back to top

Display posts from previous:  

All times are GMT
View next topic
View previous topic
Page 1 of 1
Erlang Forum - Trap Exit Forum Index  ~  Erlang patches mailing list
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
Hosted by Erlang Solutions    |    Powered by phpBB and NoseBleed 1.14